fix(datetime): use ResizeObserver to reliably detect visibility changes#30864
Open
fix(datetime): use ResizeObserver to reliably detect visibility changes#30864
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d97de23 to
1441928
Compare
d29b904 to
12ef934
Compare
273081d to
7c8b35e
Compare
7c8b35e to
a8772e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30706
What is the current behavior?
When
ion-datetimeis rendered inside a modal or popover, it may appear invisible (opacity: 0) because the datetime-ready class is not applied. This occurs because IntersectionObserver doesn't reliably detect visibility changes in some browsers (particularly WebKit/Safari) when the datetime is inside an overlay that is presented after page load.What is the new behavior?
The datetime now uses multiple strategies to reliably detect visibility:
The .intersection-tracker element has been removed as it's no longer needed.
Does this introduce a breaking change?
Other information
Current dev build: